On Oct 20, 2014, at 10:55 PM, Al Viro wrote:
> On Tue, Oct 21, 2014 at 02:13:46AM +0100, Al Viro wrote:
>> Similar to that, where is ll_d_mountpoint() ever called with NULL dchild,
>> why do you have
>> if (unlikely(dchild))
>> in there when it's true on every call and why does it exist in the first
>> place? All its callers are reachable only from vfs_{unlink,rmdir,rename}
>> and we *do* d_mountpoint() checks there.
>
> Could somebody explain what this is for?
> /* Try to find the child dentry by its name.
> If found, put the result fid into @fid. */
Hm… This is really unused.
It's also in the patch queue for syncing.
Something like this, if you are interested: http://review.whamcloud.com/6648
> Obvious jokes about exotic adenoidectomy technics aside, what's the story
> with that file? Is that just a trimmed down dual-use code that is sometimes
> called by VFS and sometimes lives in userland and called by hell knows what?
Those are all remains of that old intent-code of long ago, I believe.
Bye,
Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
