>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: >> Broken usage, IMO. If you are going to use the block layer ioctls to >> manipulate data int eh block device, you should be using direct Io >> for all your data IO to the block device. Otherwise, coherency >> problems occur.... Christoph> I'd say BLKZEROOUT semantics are broken. Having an ioctl Christoph> exposed that maniulates on-disk data without cache coherence Christoph> is a nightmare that people trip over easily. I agree it's suboptimal but it's not different from how the other block ioctls are working (discard, etc.). The main issue is that the blkdev_issue_foobar() calls were designed for in-kernel use and the calling filesystems were supposed to know what they were doing with those pages. And for convenience we just wired up the same calls as ioctls. I'm undecided as to which hammer would be best. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
