> > Namjae Jeon <namjae.jeon@xxxxxxxxxxx> writes: > > > Adding i_disksize to represent uninitialized allocated size. > > And mmu_private represent initialized allocated size. > > i_disksize - is always kept cluster size aligned > > mmu_private - is normally block size aligned > > Hi, Hi OGAWA, > > While reading this with fresh mind, I've now noticed i_disksize is > lesser i_blocks in fatfs? Yes. > > Well, if fallocate inode, what number should we return? I.e. it returns > really allocated blocks, or fake blocks in i_size? It should return allocated blocks. And i_blocks is also updated by fat_chain_add in fat_fallocate. > > If we can use i_blocks (fatfs doesn't have hole), maybe, this patch > become simpler. If not, I think we should add i_disksize changes more > like i_blocks does. Yes, We can use i_blocks instead of i_disksize. > > What do you think? As you pointed out, Using i_blocks will make this patch more simple. Thanks for review! > > Thanks. > > OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
