On Sun, Oct 12, 2014 at 03:42:39PM -0500, Eric Biggers wrote: > file = anon_inode_getfile(name, fops, priv, flags); > if (IS_ERR(file)) { > - error = PTR_ERR(file); > - goto err_put_unused_fd; > + put_unused_fd(fd); > + return PTR_ERR(file); > } > fd_install(fd, file); at least slap unlikely() on that if (IS_ERR(...))... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html