> + else {
> + spin_lock(&filp->f_lock);
> + filp->f_flags = (arg & SETFL_MASK) |
> + (filp->f_flags & ~SETFL_MASK);
> + spin_unlock(&filp->f_lock);
Please move this into an exported generic_file_set_flags helper, that
the filesystems can use in their implementations instead of duplicating
it.
Also a more conceptual question: Basically any check the filesystems
may perform needs to be duplicated in open and ->set_flags. Any chance
to have the open path call into ->set_flags?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
