[PATCH] vfs: fix linkat error for unprivileged AT_EMPTY_PATH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Miklos Szeredi <mszeredi@xxxxxxx>

Return proper error value for linkat(..., AT_EMPTY_PATH) without enough
privileges.

I guess ENOENT was used here, because without AT_EMPTY_PATH that's what
we'd return for an empty path.  But it is wrong for AT_EMPTY_PATH, since we
might not even be passing an empty path, we are simply complaining about
lack of privs for which EPERM is the proper error.

Fixes: 11a7b371b64e ("fs: allow AT_EMPTY_PATH in linkat()...")
Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx # 2.6.39+
---
 fs/namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3957,7 +3957,7 @@ SYSCALL_DEFINE5(linkat, int, olddfd, con
 	 */
 	if (flags & AT_EMPTY_PATH) {
 		if (!capable(CAP_DAC_READ_SEARCH))
-			return -ENOENT;
+			return -EPERM;
 		how = LOOKUP_EMPTY;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux