On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote:
>
> Linus flamed me for that a few weeks ago. The problem is that if one
> uses "git format-patch" to prepare a series of emails to post, that it
> users the patch's author for the From: entry. I think that is a bug
> in git since multiple people have encountered this issue. It's not
> like git doesn't know what one's email address is....
That's true, but "git send-email" takes care of doing the rewrite so
that your e-mail address is on the from line and the original author's
from: line is moved into the body of the e-mail:
% git log -1
commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10
Author: Michael Forney <forney@xxxxxxxxxx>
Date: Mon Sep 15 14:30:00 2014 -0400
Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling
Signed-off-by: Michael Forney <forney@xxxxxxxxxx>
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
% git format-patch -o /tmp/p -1
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
% head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
>From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001
From: Michael Forney <forney@xxxxxxxxxx>
Date: Mon, 15 Sep 2014 14:30:00 -0400
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when
cross-compiling
% git send-email /tmp/p --to tytso@xxxxxxx
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
(mbox) Adding cc: Michael Forney <forney@xxxxxxxxxx> from line 'From: Michael Forney <forney@xxxxxxxxxx>'
(body) Adding cc: Michael Forney <forney@xxxxxxxxxx> from line 'Signed-off-by: Michael Forney <forney@xxxxxxxxxx>'
(body) Adding cc: Theodore Ts'o <tytso@xxxxxxx> from line 'Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>'
From: Theodore Ts'o <tytso@xxxxxxx>
To: tytso@xxxxxxx
Cc: Michael Forney <forney@xxxxxxxxxx>
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling
Date: Wed, 17 Sep 2014 09:45:09 -0400
Message-Id: <1410961509-10620-1-git-send-email-tytso@xxxxxxx>
X-Mailer: git-send-email 2.1.0
Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C
% git version
git version 2.1.0
Perhaps you and other people are using your own scripts, and not using
git send-email?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
