Hi Jeff, On Friday, 12. September 2014 22:12:08 Jeff Layton wrote: > > I just compiled the VMware kernel modules 9.4.6-1770165 > > on kernel 3.14.18 (upgrading from 3.4.101). > > > > The functions getname() and putname() are both used > > by the "vmblock" and "vmsync" module. > > > > Any chance to revert 8e377d15078a501c4da98471f56396343c407d92 > > --------------------------------------- > > vfs: unexport getname and putname symbols > > > > I see no callers in module code. > > --------------------------------------- > > > > since there are callers to those functions? > > > > Otherwise the VMware code needs to be changed downstream. > > For now I've reverted the commit in question locally. > > > > Cheers, > > Thomas > > (I've left Red Hat so the redhat.com address no longer works) > > As Christoph says...no, there's no way that we'll revert that. > > Those functions have hooks into the audit layer and 3rd party modules > almost universally got their usage wrong. thanks for the explanation, especially about the audit layer part. Let's see if Dmitry still works for VMware as the @vmware.com address bounces. Adding CC: to Dyno and Dmitry (another address). Cheers, Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html