Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@xxxxxxxxxx] > Sent: Saturday, August 16, 2014 5:58 AM > To: linux-kernel@xxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; > linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [f2fs-dev] [PATCH 08/13 v2] f2fs: do checkpoint at f2fs_put_super > > Change log from v1: > o relocate F2FS_SET_SB_DIRT to avoid unnecessary checkpoints In umount, we will encounter memory leak as we may skip releasing dirty inode when IO error occurred in cp. Why not just invoking release_dirty_inode directly in f2fs_put_super? Thanks, Yu > > The generic_shutdown_super calls sync_filesystem, evict_inode, and then > f2fs_put_super. In f2fs_evict_inode, we remain some dirty inode information > so we should release them at f2fs_put_super. > > But normally, it's more reasonable to set its superblock as dirty when > evict_inode is called. > > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > --- > fs/f2fs/checkpoint.c | 1 + > fs/f2fs/super.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 7e1c13b..01e1796 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -330,6 +330,7 @@ void add_dirty_inode(struct f2fs_sb_info *sbi, nid_t ino, int type) > { > /* add new dirty ino entry into list */ > __add_ino_entry(sbi, ino, type); > + F2FS_SET_SB_DIRT(sbi); > } > > void remove_dirty_inode(struct f2fs_sb_info *sbi, nid_t ino, int type) > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 633315a..60e3554 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -432,7 +432,7 @@ static void f2fs_put_super(struct super_block *sb) > stop_gc_thread(sbi); > > /* We don't need to do checkpoint when it's clean */ > - if (sbi->s_dirty && get_pages(sbi, F2FS_DIRTY_NODES)) > + if (sbi->s_dirty) > write_checkpoint(sbi, true); > > iput(sbi->node_inode); > -- > 1.8.5.2 (Apple Git-48) > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
