On Thu, Aug 14, 2014 at 03:30:15PM -0400, Jeff Layton wrote: > > Not directly related to this patch, but... > > What's the story behind the check above? Allowing the server to overrun > the rfc1001 length by one byte seems dangerous... I vaguely remember a NetApp bug :-). > I don't understand the rationale for the arbitrary 15 byte limit. At > this point, you've already received the data. If there's extra junk at > the end, do you really care? I'd just ensure that clc_len fits within > the rfc1001 len and leave it at that. +1 on this. No arbitrary limits please. If you're going to ignore data after the valid packet, ignore everything up to the rfc1001 length please. Only ignoring 15 bytes doesn't make sense. Why 15 ? Why not 27 ? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
