Re: [RFC PATCH 1/5] proc: intoduce proc_inode->pid_entry and is_tgid_pid_entry()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 08, 2014 at 08:57:47PM +0200, Oleg Nesterov wrote:
...
> +++ b/fs/proc/inode.c
> @@ -73,6 +73,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)
>  	ei->pde = NULL;
>  	ei->sysctl = NULL;
>  	ei->sysctl_entry = NULL;
> +	ei->pid_entry = NULL;
>  	ei->ns.ns = NULL;
>  	ei->ns.ns_ops = NULL;
>  	inode = &ei->vfs_inode;

Hi Oleg, sorry for not responding to previous emails, will try to review this
things tomorrow (from a glance looks quite good!). Btw, this moment strike my
eyes -- why don't we use kmem_cache_zalloc here but do assign nils again and
again, maybe worth to address as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux