On Tue, Aug 05, 2014 at 09:47:03PM +0200, Oleg Nesterov wrote: > 1. Kill the first "vma != NULL" check. Firstly this is not possible, > m_next() won't be called if ->start() or the previous ->next() > returns NULL. > > And if it was possible the 2nd "vma != tail_vma" check is buggy, > we should not wrongly return ->tail_vma. > > 2. Make this function readable. The logic is very simple, we should > return check "vma != tail" once and return "vm_next || tail_vma". > > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
