On Fri, 25 Jul 2014 12:38:08 -0500
Abhi Das <adas@xxxxxxxxxx> wrote:
> This patch adds support in GFS2 for the xgetdents syscall by
> implementing the xreaddir file operation.
So I was trying to make sense of this, and ran into one little thing that
jumped out at me:
> +static int gfs2_xrdir_to_user_vars(struct gfs2_xrdir_ctx *xc,
> + struct gfs2_xdirent *x,
> + struct gfs2_xdirent *x_vb_p,
> + struct linux_xdirent __user *lxd,
> + size_t count, size_t *bytes)
Now, I'll readily admit that I could be overly confused by this function.
When the variables are named "x", "xx", "xc", "x_vb_p", "xblob", and "lxd",
it all starts to run together. But still...
> + if ((xc->xc_xattr_mask & XSTAT_XATTR_ALL) &&
> + lxd->xd_blob.xb_xattr_count) {
How can that be right? lxd is __user, it doesn't seem right to be
dereferencing it directly...?
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
