On Fri, 2014-07-18 at 13:01 +0400, Vyacheslav Dubeyko wrote:
> On Fri, 2014-07-18 at 11:35 +0300, Sougata Santra wrote:
>
> [snip]
> > 2) Also, there was a error in error propagation. It it also fixed in
> > this patch.
> > -->snip<--
> > if (!error)
> > error2 = error;
> > -->snap<--
> >
> > 3) The disk is only flushed if there was no error. Previously it was
> > always flushed without checking the error.
>
> So, do you mean that filemap_write_and_wait() and hfsplus_submit_bio()
> doesn't request writing on a volume?
Yes it did, but it wrote in the page-cache ?.
> What do you mean when you are
> talking about absence of flush? I think that I have misunderstanding of
> the description.
AFAIK, blkdev_issue_flush() is issued to flush the write back cache of
the block device if it supports REQUEST_FLUSH. I did not understand the
need to flush the disk cache to send everything into non-volatile
memory when writing to page-cache returned some error. If the error
checking is not required, then I can remove it.
>
> Thanks,
> Vyacheslav Dubeyko.
>
>
Thanks a lot,
Sougata.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
