On Wed, 09 Jul 2014 15:33:21 +0900, Namjae Jeon <namjae.jeon@xxxxxxxxxxx> wrote: > > > > On Tue, Jul 08, 2014 at 08:59:49PM +0900, Namjae Jeon wrote: > > > This patch implements fs ioctl's IOC_MOV_DATA for XFS. > > > > Shouldn't this share code with the XFS_IOC_SWAPEXT implementation? > Lukas has raised the same question for ext4. > Both xfs(XFS_IOC_SWAPEXT) and ext4(EXT4_IOC_MOVE_EXT) has ioctls which uses > almost similar kind of structure as struct mov_data. > As such, there seems to be possiblity for sharing basic code (I will try) > used for sanity checking in IOC_MOV_DATA to be shared with these ioctls > but the core functionality code will remain different. > > Thanks! Actually they are differ. EXT4_IOC_MOVE_EXT copy data inside kernel, but XFS_IOC_SWAPEXT live this job to userpsace see: http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfsprogs.git;a=blob;f=fsr/xfs_fsr.c packfile And I'll vote to make EXT4_IOC_MOVE_EXT deprecated, and implement EXT4_IOC_SWAPEXT as XFS does that. Ted, Lukas what do you think about that? > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
