On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote: > The above function looks like almost verbatim copy of print_hex_dump(). The only > difference I can spot is that it's calling seq_printf() instead of printk(). Can > you not instead generalize print_hex_dump() and based on it's invocation, make > it call either seq_printf() or printk() ? How do you propose doing that given any seq_<foo> call requires a struct seq_file * and print_hex_dump needs a KERN_<LEVEL>. Is there an actual value to it? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html