Re: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 5 Jun 2014, chishanmingshen wrote:

> Date: Thu,  5 Jun 2014 19:55:09 +0800
> From: chishanmingshen <chishanmingshen@xxxxxxxxx>
> To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: linux-fsdevel@xxxxxxxxxxxxxxx, chishanmingshen <chishanmingshen@xxxxxxxxx>
> Subject: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
> 
> Just skip the unrelated buffer heads when clear buffer head's BH_new flag.

I can see that from the code, but can you explain why in the commit
description ?

Thanks!
-Lukas

> This patch is *untested*.
> 
> Signed-off-by: chishanmingshen <chishanmingshen@xxxxxxxxx>
> ---
>  fs/buffer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 9ddb9fc..a28a1a1 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1987,8 +1987,8 @@ static int __block_commit_write(struct inode *inode, struct page *page,
>  		} else {
>  			set_buffer_uptodate(bh);
>  			mark_buffer_dirty(bh);
> +			clear_buffer_new(bh);
>  		}
> -		clear_buffer_new(bh);
>  
>  		block_start = block_end;
>  		bh = bh->b_this_page;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux