On Tue, Jun 17, 2014 at 01:55:26PM +0200, Lukáš Czerner wrote: > > I definitely agree with Dave here it is an ugly API hack. Fallocate > seems much more suitable for this. > > New flag FALLOC_FL_ISSUE_DISCARD which would work with > FALLOC_FL_PUNCH_HOLE, FALLOC_FL_ZERO_RANGE and possibly > FALLOC_FL_COLLAPSE_RANGE might actually be useful. I agree it would be useful to have an FL_ISSUE_DISCARD (and while we're at it, FL_ISSUE_SECDISCARD) as an fallocate flag. That doesn't obviate the usefulness of a BLKDISCARD ioctl for ext4 files, though. Something else that might be useful, and perhaps more appropriate for the Android use case, is to add a SECDISCARD flag to the unlinkat(2) system call. That way, people who want to do a "discard and then unlink" don't have to be forced to do an open(2), fallocate(2), close(2), and only *then* the unlink(2) system call. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
