[PATCH] fat: Fix missed error code by "add support for DOS 1.x formatted volumes"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>                        " (logical sector size = %u)", logical_sector_size);
>> _
>> --
>> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Conrad Meyer <cse.cem@xxxxxxxxx>
>
> Patch LGTM. Apologies for missing this on the first go-around.

Thanks for review.

Please apply the following patch to fix "add support for DOS 1.x
formatted volumes" patch.

Thanks.

---
Subject: [PATCH] fat: Fix missed error code by "add support for DOS 1.x formatted volumes"

In "add support for DOS 1.x formatted volumes" patch, "error" is
overwritten by fat_read_bpb().

This patch reset "error" to -EIO, to return proper error.

Reviewed-by: Conrad Meyer <cse.cem@xxxxxxxxx>
Signed-off-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
---

 fs/fat/inode.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN fs/fat/inode.c~fat-fix-error-handling fs/fat/inode.c
--- linux-next/fs/fat/inode.c~fat-fix-error-handling	2014-06-03 00:20:03.773448083 +0900
+++ linux-next-hirofumi/fs/fat/inode.c	2014-06-03 00:20:08.717435605 +0900
@@ -1622,6 +1622,7 @@ int fat_fill_super(struct super_block *s
 	logical_sector_size = bpb.fat_sector_size;
 	sbi->sec_per_clus = bpb.fat_sec_per_clus;
 
+	error = -EIO;
 	if (logical_sector_size < sb->s_blocksize) {
 		fat_msg(sb, KERN_ERR, "logical sector size too small for device"
 		       " (logical sector size = %u)", logical_sector_size);
_
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux