On Fri 02-05-14 07:44:09, Christoph Hellwig wrote: > On Fri, May 02, 2014 at 03:19:58PM +0200, Jan Kara wrote: > > There are parts of struct inode which are used only by a few filesystems > > (e.g. i_dquot pointers, i_mapping->private_list, ...). Thus all the > > Why don't you move the private_list into the fs inode like you did > in the previous few patches and remove the references from the generic > code? This would involve some heavy lifting in buffer.c, but that's > long overdue anyway. So I was looking into that option as well and even had some prelimiary patch. It is certainly doable but it seemed a bit ugly to pass around another pointer for the list of metadata buffers. It is especially ugly for stuff like remove_inode_buffers() or invalidate_inode_buffers(). There we'd have to provide new filesystem callbacks or something like that... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
