On Wed, Apr 30, 2014 at 05:49:58PM +0200, Miklos Szeredi wrote: > > FWIW, the first two are really straightforward expanding the function > > into its only callsite. The last needs more splitup. Not sure if the > > following is good enough, but it ought to be at least somewhat cleaner. > > Combined change is identical to the original, so it doesn't invalidate > > the testing so far... > > Hmm, patches look okay, but I'm wondering if we really need the morgue list and > the waiting. Why not just skip dentries that are presently being handled by > dentry_kill()? Who will be freeing them? If we do that from dentry_kill(), we are back to needing them removed from shrink list by something called by dput(). And if we do that from shrink_dentry_list(), we'd damn better wait for dentry_iput() et.al. to finish. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
