On Thu, 24 Apr 2014 12:08:13 +0200 Jan Kara <jack@xxxxxxx> wrote: > On Wed 23-04-14 15:09:22, Andrew Morton wrote: > > Subject: + fs-isofs-logging-clean-up.patch added to -mm tree > > To: fabf@xxxxxxxxx,jack@xxxxxxx,joe@xxxxxxxxxxx,viro@xxxxxxxxxxxxxxxxxx > > From: akpm@xxxxxxxxxxxxxxxxxxxx > > Date: Wed, 23 Apr 2014 15:09:22 -0700 > > > > > > The patch titled > > Subject: fs/isofs: logging clean-up > > has been added to the -mm tree. Its filename is > > fs-isofs-logging-clean-up.patch > > > > This patch should soon appear at > > http://ozlabs.org/~akpm/mmots/broken-out/fs-isofs-logging-clean-up.patch > > and later at > > http://ozlabs.org/~akpm/mmotm/broken-out/fs-isofs-logging-clean-up.patch > > > > Before you just go and hit "reply", please: > > a) Consider who else should be cc'ed > > b) Prefer to cc a suitable mailing list as well > > c) Ideally: find the original patch on the mailing list and do a > > reply-to-all to that, adding suitable additional cc's > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > The -mm tree is included into linux-next and is updated > > there every 3-4 working days > > > > ------------------------------------------------------ > > From: Fabian Frederick <fabf@xxxxxxxxx> > > Subject: fs/isofs: logging clean-up > > > > -All printk(KERN_foo converted to pr_foo() > > -Default printk converted to pr_warn() > > -Define DEBUG in pr_debug callsites to keep old printk(DEBUG behaviour > > -Add DEBUG_FLAGS in Makefile for previous #ifdef DEBUG > > -Coalesce format fragments. > > -Separate format/arguments on lines > 80 characters. > > -Add ISOFS, ISOFS Rock, zisofs pr_fmt > > > > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx> > > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > Cc: Jan Kara <jack@xxxxxxx> > > Cc: Joe Perches <joe@xxxxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Fabian, I'm OK with the patch but when already touching all the places > that print something in isofs, could you please do what other filesystems > to and print also sb->s_id with the message? So interface like ext2_msg() > has would be nice I think... Thanks! btw, wouldn't be possible/interesting to define common functions for that rather than define those again and again ? Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
