On Tue, Apr 22, 2014 at 05:45:31PM +0300, Boaz Harrosh wrote: > On 04/22/2014 03:23 PM, Jeff Layton wrote: > <> > > > > We're going to have to live with these for a long time, so it's > > important that we be happy with the names before we're stuck with them. > > The consensus on the lists so far is that they should be rechristened as > > "open file description locks". > > > > I completely agree with the rename. (Though could you please post > the rest of the rename patches for review) > > Just a very small nit. My native language is not English but I would > rather you use "file-descriptor" (with an '-' as well) and not > use "description" in the English name of the lock. This is > because stated like that, "description" might refer to the > locks and not to the file in the sentence. file-descriptor is > more clear I think. (For me it was confusing at first before I realized > what you meant) I think you missed the whole point. "File descriptor" and "open file description" have DIFFERENT meanings. Replacing one with the other gives the wrong meaning. Rich -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
