On Mon, Apr 21, 2014 at 09:22:48AM -0700, Andy Lutomirski wrote: > +static int proc_may_follow(struct nameidata *nd, struct file *f) > +{ > + if (!nd) > + return 0; /* This is readlink, */ > + > + if ((nd->flags & LOOKUP_WRITE) && !(f->f_mode & FMODE_WRITE)) > + return -EACCES; > + > + return 0; > +} And this is just plain wrong. WTF are you making the traversal of symlink in the middle of pathname dependent on the open flags? NAK. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html