On Thu, Apr 17, 2014 at 5:59 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Apr 17, 2014 at 03:40:05PM +0200, Michael Kerrisk (man-pages) wrote: >> On 04/16/2014 08:05 AM, Christoph Hellwig wrote: >> > Michael, can you apply this now that we merged FALLOC_FL_COLLAPSE_RANGE >> > into the kernel tree? >> >> I've applied Namjae Jeon's patch (thanks Namjae!), and done a lot of >> tweaking to generate the patch below. >> >> Along the way I noticed that there is an inconsistency between XFS >> and JFS that should be fixed (and so have added Dave and Ted to CC, > > ext4? D'oh -- yes! > Anyway, the documentation looks good to in general, but do you really think > mentioning git commit hashs in a man page is a good idea? Those are only comments in the source file, for reference (sometimes, that's really helpful). They don't appear the rendered output. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html