Hi Vyacheslav, Thanks for letting me know. Indeed it looks functionally identical. I'll try cherry-pick and see - it should colide at every change and resolve to nothing. Hin-Tak -------------------------------------------- On Tue, 15/4/14, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: Subject: Re: [PATCH 4/4] hfsplus: fixes error propagation of hfsplus_asc2uni To: "Hin-Tak Leung" <hintak.leung@xxxxxxxxx> Cc: linux-fsdevel@xxxxxxxxxxxxxxx, "Al Viro" <viro@xxxxxxxxxxxxxxxxxx>, "Christoph Hellwig" <hch@xxxxxxxxxxxxx>, "Anton Altaparmakov" <aia21@xxxxxxxxx>, "Hin-Tak Leung" <htl10@xxxxxxxxxxxxxxxxxxxxx> Date: Tuesday, 15 April, 2014, 7:55 Hi Hin-Tak, On Tue, 2014-04-15 at 05:20 +0100, Hin-Tak Leung wrote: > From: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx> > > hfsplus_asc2uni() converts NLS strings to unicode on-disk representation. > It can fail if the input is tool long to fit the destination > (255 unicode characters for files and 127 for attributes). > The error propagation for attributes (only one usage of hfsplus_asc2uni() > in hfsplus_attr_cat_build_key() ) is part of an earlier patch. > > In the catalog code, hfsplus_asc2uni() is used by two routines, > hfsplus_cat_build_key() and hfsplus_fill_cat_thread(). > The prototypes of those two are extended, and all callers to these two > routines now check and try to catch errors from them. > As I remember, this work has been done by Sougata Santra <sougata@xxxxxxxxxx>. And his patch [1], [2] in the next tree now. Could you check that you've add something new? Thanks, Vyacheslav Dubeyko. [1] https://lkml.org/lkml/2014/2/24/498 [2] https://lkml.org/lkml/2014/2/24/807 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
