On Sun 13-04-14 18:10:30, xypron.glpk@xxxxxx wrote: > From: Heinrich Schuchardt <xypron.glpk@xxxxxx> > > Before the patch, > read creates FAN_ACCESS_PERM and FAN_ACCESS events, > readdir creates only FAN_ACCESS_PERM events. > > This is inconsistent. > > After the patch, > readdir creates FAN_ACCESS_PERM and FAN_ACCESS events. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx> Makes sense. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/readdir.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/readdir.c b/fs/readdir.c > index 5b53d99..33fd922 100644 > --- a/fs/readdir.c > +++ b/fs/readdir.c > @@ -13,6 +13,7 @@ > #include <linux/stat.h> > #include <linux/file.h> > #include <linux/fs.h> > +#include <linux/fsnotify.h> > #include <linux/dirent.h> > #include <linux/security.h> > #include <linux/syscalls.h> > @@ -40,6 +41,7 @@ int iterate_dir(struct file *file, struct dir_context *ctx) > ctx->pos = file->f_pos; > res = file->f_op->iterate(file, ctx); > file->f_pos = ctx->pos; > + fsnotify_access(file); > file_accessed(file); > } > mutex_unlock(&inode->i_mutex); > -- > 1.7.10.4 > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html