Hi, On 8 Apr 2014, at 17:55, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > On Apr 8, 2014, at 8:43 PM, Hin-Tak Leung wrote: > [snip] >>> Yes, it is possible to split the work on several patches. I agree with >>> it. >>> >>> But I suppose that these patches needs to be joined in one patchset. >>> Because reported issue can be solved by fix as for file names as for >>> xattr names. >>> >>> Of course, it is possible to fix the issue with file names, firstly, and >>> then the issue with xattr names. But it doesn't make sense to mix fixes >>> for file names and for xattr names in one patch. Because partial fix in >>> hfsplus_listxattr() doesn't fix the issue for xattr names. >>> >> >> Think of it as "fixes worst-case usage of hfsplus_uni2asc()", >> then it makes sense to have this as one patch. Allowing full usage >> of getting and setting of long multi-lingual attributes, and checking >> other uses of HFSPLUS_ATTR_MAX_STRLEN really need to be another >> (multiple others). >> >> There are only two usages of hfsplus_uni2asc(), one for names and >> one for attributes. > > Unfortunately, it doesn't make sense to have fix only in hfsplus_listxattr(). > It fixes nothing for xattr names. Of course, you can mention name of the patch. :) > But such partial fix doesn't make sense for me. It will be more clear way to have > one patch for file names and another patch for xattr names. You are entitled to your opinion but I agree with Hin-Tak. This makes perfect sense as it fixes the use of a function which can otherwise cause an erroneous EIO error to be returned from listxattr(). This in itself is a worthwhile fix. Your idea of having to fix everything or nothing at all is frankly quite silly and would mean that hardly anything ever gets fixed... Fixing small problems individually is just fine, especially when they are such obvious ones. Best regards, Anton > Thanks, > Vyacheslav Dubeyko. -- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) Unix Support, Computing Service, University of Cambridge J.J. Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
