------------------------------ On Tue, Apr 8, 2014 8:05 AM BST Vyacheslav Dubeyko wrote: <snipped> >I think that you missed likewise cases in: About those bunch of files, I think it needs a 2nd patch. The choice is just between whether to put the attribute-related uni2asc part of the fix with the uni2asc name fix, or put it together with this 2nd one. 85+ CJK-character file names are quite conceivable (255 / 3 = 85). attributes in HFS+ are new, and usage of them - and usage with with long and exotic charsets are probably still rare; so there is different urgency to the two. Also this whole bunch is rather a different matter - as I said, some are about setting long attributes. Not being able to read long attributes (written by a different OS, very likely), is quite a different matter from not being about to write long attributes (you try to write, it doesn't work, hopefully you get a message saying it is too long, and you try something else, shorten and abbreviate your attribute, etc). Also, none of them are directly hooked up to uni2asc, so there are probably a 3rd item besides expanding the buffer size, error recovery from failed allocation: error recovery of these from the bottom listattr (I think that's the one that actually use uni2asc) feeding them something too large for their liking. Hin-Tak >(1) hfsplus_attr_build_key() >(http://lxr.free-electrons.com/source/fs/hfsplus/attributes.c#L58) > >(2) xattr_security.c >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L17) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L23) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L35) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L41) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L65) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_security.c#L76) > >(3) xattr_trusted.c >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_trusted.c#L15) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_trusted.c#L21) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_trusted.c#L33) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_trusted.c#L39) > >(4) xattr_user.c >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_user.c#L15) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_user.c#L21) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_user.c#L33) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr_user.c#L39) > >(5) hfsplus_osx_getxattr() >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr.c#L800) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr.c#L807) > >(6) hfsplus_osx_setxattr() >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr.c#L823) >(http://lxr.free-electrons.com/source/fs/hfsplus/xattr.c#L830) > >Thanks, >Vyacheslav Dubeyko. > > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
