On Sun, Mar 23, 2014 at 03:35:05PM +0000, Al Viro wrote:
> On Sun, Mar 23, 2014 at 11:57:16AM +0100, Sedat Dilek wrote:
>
> > Your branch on top of Linux v3.14-rc7-66-g774868c7094d is freezing my
> > Ubuntu/precise AMD64 (WUBI) system when running LTP.
>
> Which test?
Argh... I see what's going on; could you check if the following fixes all
the problems you are seeing?
diff --git a/fs/namespace.c b/fs/namespace.c
index d6e6daf..2ffc5a2 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -746,7 +746,7 @@ static void detach_mnt(struct mount *mnt, struct path *old_path)
mnt->mnt_parent = mnt;
mnt->mnt_mountpoint = mnt->mnt.mnt_root;
list_del_init(&mnt->mnt_child);
- hlist_del_rcu(&mnt->mnt_hash);
+ hlist_del_init_rcu(&mnt->mnt_hash);
put_mountpoint(mnt->mnt_mp);
mnt->mnt_mp = NULL;
}
@@ -1236,7 +1236,7 @@ void umount_tree(struct mount *mnt, int how)
struct mount *last = NULL;
for (p = mnt; p; p = next_mnt(p, mnt)) {
- hlist_del_rcu(&p->mnt_hash);
+ hlist_del_init_rcu(&p->mnt_hash);
hlist_add_head(&p->mnt_hash, &tmp_list);
}
diff --git a/fs/pnode.c b/fs/pnode.c
index 72aa2b7..88396df 100644
--- a/fs/pnode.c
+++ b/fs/pnode.c
@@ -341,7 +341,7 @@ static void __propagate_umount(struct mount *mnt)
* other children
*/
if (child && list_empty(&child->mnt_mounts)) {
- hlist_del_rcu(&child->mnt_hash);
+ hlist_del_init_rcu(&child->mnt_hash);
hlist_add_before_rcu(&child->mnt_hash, &mnt->mnt_hash);
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
