On Fri, Mar 14, 2014 at 11:11 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: > Hello, > > On Fri, Mar 14, 2014 at 11:07:04PM +0900, Roman Peniaev wrote: >> Seems the following message should be better: >> When data inegrity operation (sync, fsync, fdatasync calls) happens >> writeback control is set to WB_SYNC_ALL. >> In that case all write requests are marked with WRITE_SYNC, but on >> mpage writeback path >> WRITE_SYNC is missed. This patch fixes this. >> >> Is it ok, what do you think? > > I think the description should make it clear that WRITE_SYNC is about > latency, not about integrity and we probably should add comments > explaining why we're using WRITE_SYNC for WB_SYNC_ALL (because there > probably is someone waiting). I sent v2 of the patch where I tried to be more explicit in details. Please, check. -- Roman -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
