On Thu, 6 Mar 2014, Christoph Hellwig wrote:
> Date: Thu, 6 Mar 2014 09:48:13 -0800
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
> Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f
>
> > +#ifdef HAVE_LINUX_FIEMAP_H
> > +struct print_flags fiemap_flags[] = {
> > + { FIEMAP_FLAG_SYNC, "SYNC"},
> > + { FIEMAP_FLAG_XATTR, "XATTR"},
> > + { -1, NULL}
> > +};
>
> Can be static.
Right. The same applies to falloc_flags
>
> > +
> > +#define translate_fiemap_flags(mode) \
> > + ({translate_flags(mode, "|", fiemap_flags);})
> > +#endif
>
> Any reason to not have these two inside fiemap_f?
Not really, other than I think it's ugly.
>
> Otherwise:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks!
-Lukas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
