On Mon, 2014-02-24 at 10:59 +0100, Sergei Antonov wrote: > On 12 February 2014 15:24, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > > Hi, > > > > This is third version of patchset that implements journal replay > > functionality in HFS+ file system driver. > > Causes file system errors after trying to replay journal on iPod Nano > 8GB with 4K sector size. Details follow. My implementation "[PATCH] > hfsplus: add journal replay" works fine. > If you have found some bug then you can report about it. And I'll fix it after reproducing. But it doesn't mean that it needs to suggest the patch instead of mine. It needs to cooperate. And nobody prevented you from sharing your patch before mine. I think that suggesting a patch after existing of another one is dishonest way and simply cheating. Yesterday I published fourth version of the patch. Do you have the same result for this version? Could you describe in more details how I can reproduce the issue? Thanks, Vyacheslav Dubeyko. > fsck_hfs output: > Verifying volume disk2s2 > Checking file system > Checking Journaled HFS Plus volume. > Checking extents overflow file.Checking catalog file. > Checking multi-linked files.Checking catalog hierarchy. > Checking extended attributes file. > Unused node is not erased (node = 53) > Checking volume bitmap. > Volume bitmap needs minor repair for under-allocation > Checking volume information. > Volume header needs minor repairThe volume Sergei Antonov’s iPod was > found corrupt and needs to be repaired. > Error: This disk needs to be repaired. Click Repair Disk. > > In system log: > Feb 24 10:45:31 sas-MacBook-Pro kernel[0]: jnl: disk2s2: do_jnl_io: > strategy err 0x6 > Feb 24 10:45:31 sas-MacBook-Pro kernel[0]: jnl: disk2s2: > end_transaction: only wrote 0 of 147456 bytes to the journal! > Feb 24 10:45:31 sas-MacBook-Pro kernel[0]: hfs: unmount initiated on > Sergei Antonovs iPod on device disk2s2 > Feb 24 10:45:31 sas-MacBook-Pro kernel[0]: jnl: disk2s2: close: > journal 0xffffff8015507a80, is invalid. aborting outstanding > transactions > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html