Re: [PATCH RFC] block: use discard if possible in blkdev_issue_discard()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Ted" == Theodore Ts'o <tytso@xxxxxxx> writes:

Ted,

[issue_zeroout_or_write_same]

Ted> How do people think I should implement this functionality?  I see
Ted> three possible choices:

I did think about doing this when I originally implemented support for
WRITE SAME. However, one caveat is that there are corner cases where
devices that -- despite reporting that they return zeroed data after
TRIM -- will return non-zeroes. The issue being that TRIM is a hint and
there are no hard guarantees. Even if a device reports DRAT/RZAT.

So the reason I didn't end up adding a call like yours is that the
result is non-deterministic. The call would have to be "please zero this
block range but I don't *actually* rely on getting zeroes back". I don't
have a problem providing a function that does that as long as the
best-effort limitation is made crystal clear.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux