On Mon, Feb 10, 2014 at 09:51:45PM +1100, Dave Chinner wrote: > On Fri, Feb 07, 2014 at 05:48:58PM +0100, Miklos Szeredi wrote: > > Changes since the last version (based on Al's review): > > > > - cross-rename: fix locking of nondirectories for NFSv4 > > - ext4: split cross-rename and plain rename into separate functions > > - introduce i_op->rename2 with flags, don't touch ->rename > > - last (optional) patch to merge ->rename2 back into ->rename > > > > The splitting of the ext4 implemetation was indeed a good idea as it uncovered a > > memory leak and small inconsistencies with the merged implementation. > > > > Splitting out rename2 will lessen the code churn, but I think is ugly. However > > this is a question of taste, last patch can be ommitted without loss of > > functionality. > > > > Bruce, could you please review the locking and delegation thing in patch #8 > > "vfs: add cross-rename"? > > > > Git tree is here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git cross-rename > > Miklos, can you please write an xfstest for this new API? That way > we can verify that the behaviour is as documented, and we can ensure > that when we implement it on other filesystems it works exactly the > same on all filesystems? Splendid idea. Will do. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
