On Mon, Feb 10, 2014 at 09:47:47PM +1100, Dave Chinner wrote: > and the updated pos value on O_APPEND writes is never folded back > into ppos. Not true. Check generic_file_buffered_write() and generic_file_direct_write() - that's where it's normally stored into iocb->ki_pos (via *ppos). And yes, I agree that the damn thing is obfuscated to hell and back - other commits in my local tree kill 'ppos' arguments of __generic_file_aio_write() and generic_file_buffered_write() (equal to &iocb->ki_pos for all call sites), which makes it a bit easier to keep track of. Will push that part of queue into vfs.git#iov_iter today... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
