On 7 February 2014 22:22, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 7 Feb 2014 20:35:59 +0100 Sergei Antonov <saproj@xxxxxxxxx> wrote: > >> This patch adds support for HFSX 'HasFolderCount' flag and a corresponding >> 'folderCount' field in folder records. (For reference see HFS_FOLDERCOUNT >> and kHFSHasFolderCountBit/kHFSHasFolderCountMask in Apple's source code.) >> [skip] > > Two of hfsplus_rename_cat()'s callers hold vh_mutex, hfsplus_rename() > does not. Which lock is preventing the obvious races here? Each inode has its own counter and every counter increment and decrement is done while inode->i_mutex is locked. Andrew, in http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-hfsx-subfolder-count-support.patch the explanation got corrupted a little. It begins with "tAdd adds support for". It probably has to be "Add support for". -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html