Re: [PATCH] hfsplus: add HFSX subfolder count support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Vyacheslav Dubeyko wrote:
>> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
>> index fa929f3..7d18221 100644
>> --- a/fs/hfsplus/inode.c
>> +++ b/fs/hfsplus/inode.c
>> @@ -494,6 +494,7 @@ int hfsplus_cat_read_inode(struct inode *inode, struct hfs_find_data *fd)
>>        inode->i_ctime = hfsp_mt2ut(folder->attribute_mod_date);
>>        HFSPLUS_I(inode)->create_date = folder->create_date;
>>        HFSPLUS_I(inode)->fs_blocks = 0;
>> +        HFSPLUS_I(inode)->folder_count = be32_to_cpu(folder->folder_count);
> 
> You check HFSPLUS_HAS_FOLDER_COUNT flag below in hfsplus_cat_write_inode()
> but you don't check here. Are you sure that it is right way?

Thanks for review, Vyacheslav.
Yes. I omit a check here and in decrement/increment code. The only check which must be done is when the record is written to the disk.--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux