Miklos Szeredi wrote: > + > + if (flags) > + return -EOPNOTSUPP; > + If (at least for now) only ext4 interprets renameat2() flags, I think adding a new member to "struct inode_operations" and check it like if (!old_dir->i_op->swapname) return -EOPNOTSUPP; or if (!(old_dir->i_op->supported_features & flags)) return -EOPNOTSUPP; earlier is smarter than scattering if (flags) return -EOPNOTSUPP; into individual rename function. If we do above change, LSM can omit checking permission for cross rename operation which after all fails with -EOPNOTSUPP. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html