On Sat 04-01-14 19:36:12, Josef Bacik wrote: > > On 01/03/2014 05:17 PM, Andreas Dilger wrote: > >Shouldn't this be -EOPNOTSUPP, since -EINVAL is for incorrect arguments, which isn't the case here. > > > I think we want to be consistent with previous kernels which would > return -EINVAL if whence wasn't set properly, hopefully breaking as > few userspace stuff as possible. Thanks, Yeah, that's exactly why I chose -EINVAL instead of a bit more logical -EOPNOTSUPP. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
