On Thu, 2013-12-26 at 02:45 -0800, Christoph Hellwig wrote: > So let's look at the case of a fgetxattr(fd, "osx.foo", ...) with the old > and my new code. > > Old: > > \--- sys_fgetxattr(fd, "osx.foo", .... > \ ... > \--- generic_getxattr(dentry, "osx.foo", ... > \ [xattr_resolve_name strips the prefix] > \--- hfsplus_osx_getxattr(dentry, "foo", ... > \ [adds back prefix] > \ ... > \--- __hfsplus_getxattr(dentry, "osx.foo", ... > \ [strips the prefix again] > \--- hfsplus_find_attr(sb, ino, "foo", ... > > > New: > > \--- sys_fgetxattr(fd, "osx.foo", .... > \ ... > \--- generic_getxattr(dentry, "osx.foo", ... > \ [xattr_resolve_name strips the prefix] > \--- hfsplus_osx_getxattr(dentry, "foo", ... > \ ... > \--- __hfsplus_getxattr(dentry, "foo", ... > \--- hfsplus_find_attr(sb, ino, "foo", ... > Great. :) Thank you for explanation. So, the patch is fully correct for the new scheme of name resolving. Reviewed-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx> Thanks, Vyacheslav Dubeyko. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
