OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes: > "NODA, Kai" <nodakai@xxxxxxxxx> writes: > >> From: "NODA, Kai" <nodakai@xxxxxxxxx> >> >> FAT_MAX_DIR_ENTRIES entries in a normal directory should be permitted as >> per the FAT spec. Previously the max number of entries was >> FAT_MAX_DIR_ENTRIES - 1 due to the bug. >> >> Signed-off-by: NODA, Kai <nodakai@xxxxxxxxx> > > Looks good. > > Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> NAK, after re-read. Actually, this was wrong fix. After read last entry of block, fat_get_entry() returns -1. So, pos is not checked. In short, this allows FAT_MAX_DIR_ENTRIES+1, not FAT_MAX_DIR_ENTRIES, right? Please fix the patch, and really test it. -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
