Re: Argument type for FS_IOC_GETFLAGS/FS_IOC_SETFLAGS ioctls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 19, 2013 at 12:20:32PM -0600, Rob Browning wrote:
> "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> writes:
> 
> > On Tue, Nov 26, 2013 at 09:05:59PM +0100, Aurelien Jarno wrote:
> 
> > It also causes problems with FUSE, because the kernel fuse driver expects to be
> > able to transfer a ulong to and from userspace, but chattr & friends only
> > allocate an int on the stack, so stack mashing seems to happen.
> >
> > I complained to tytso about it on linux-ext4 a while ago, he suggested
> > special-casing fuse... I haven't gotten around to doing that.
> 
> So if we didn't make a mistake, we changed bup to use int as suggested
> by this thread, and now it appears to crash at least sometimes when FUSE
> is involved:
> 
>   https://groups.google.com/forum/#!topic/bup-list/QxcHthbLHjw
> 
> Is the problem (you mentioned above) that FUSE always expects a long,
> and if so, is there a way to tell that we're talking to FUSE?

I'm still leaning towards fixing FUSE[1], and letting userland keep on using
int, like (most?) programs always have.

The interface is still in hard shape, but this at least gets us to a place
where all the Linux filesystems behave the same -- (int *) argument.

--D

[1] Look for "[PATCH] fuse: Fix IOC_[GS]ETFLAGS argument size brokenness" on
    lkml/fsdevel.

> 
> Thanks
> -- 
> Rob Browning
> rlb @defaultvalue.org and @debian.org
> GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
> GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux