On 12/14 2013 00:32 AM, Christoph Hellwig wrote: >> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) >> +{ >> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) >> + return xfs_get_projid(dp); >> + else >> + return XFS_PROJID_DEFAULT; >> +} > > You could skip the else here. Except that, I'd suggest we move this helper to proper header file with further refactoring in xfs_symlink(), and it could be a separate patch. Thanks, -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html