Re: [PATCH 1/3] inotify: Provide function for name length rounding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 11-12-13 03:22:00, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 12:36:57AM +0100, Jan Kara wrote:
> > Rounding of name length when passing it to userspace was done in several
> > places. Provide a function to do it and use it in all places.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
  Thanks!

> BTw, I hadn't noticed kernel.h has a roundup() in addition to
> round_up().  And XFS also has roundup64 which isn't needed as far as I
> can see..  None of them are documented in the slightest way either,
> ugh..
  Yeah... There should be a note somewhere that round_up() works only for
y being a power of 2.

								Honza

-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux