On Tue, Dec 03, 2013 at 02:00:16PM -0800, Kent Overstreet wrote: > This replaces some of the code that was in __bio_map_user_iov(), and > soon we're going to use this helper in the dio code. > > Note that this relies on the recent change to make > generic_make_request() take arbitrary sized bios - we're not using > bio_add_page() here. __bio_map_user_iov was using bio_add_pc_page anyway. I might misremember some of the earlier patches, but how do you do arbitrary splitting of BLOCK_PC bios? Given that they come with a SCSI CDB attached I can't see how we could split them at all. Also when you factor code out and change behaviour please always try to do that in two separate patches so that it's easier reviewable. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
