Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> writes:
> struct page *page;
> repeat:
> page = grab_cache_page(mapping, index);
> - if (!page) {
> + if (unlikely(!page)) {
This is completely pointless, gcc already considers any test for NULL
unlikely.
In general i would advise against splattering unlikely all over your
code, the benefits are very minimal and programers often get it wrong.
-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
