From: Younger Liu <liuyiyang@xxxxxxxxxxx> When debugfs_create_file() failed in f2fs_create_root_stats(), debugfs_root should be removed. Signed-off-by: Younger Liu <liuyiyang@xxxxxxxxxxx> Cc: Younger Liu <younger.liucn@xxxxxxxxx> Cc: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> --- fs/f2fs/debug.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index a84b0a8..d27b689 100644 --- a/fs/f2fs/debug.c +++ b/fs/f2fs/debug.c @@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi) void __init f2fs_create_root_stats(void) { + struct dentry *file; + debugfs_root = debugfs_create_dir("f2fs", NULL); - if (debugfs_root) - debugfs_create_file("status", S_IRUGO, debugfs_root, - NULL, &stat_fops); + if (!debugfs_root) + goto bail; + + file = debugfs_create_file("status", S_IRUGO, + debugfs_root, NULL, &stat_fops); + if (!file) + goto free_debugfs_dir; + + return; + +free_debugfs_dir: + debugfs_remove(debugfs_root); + +bail: + return; } void f2fs_destroy_root_stats(void) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html