Re: inode_permission NULL pointer dereference in 3.13-rc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 28, 2013 at 6:07 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>    Thus the
> comment about unbalanced dput() somewhere; the question is _where_ had
> that dput() been.

Clearing the LOOKUP_RCU bit is what I was looking at, because doing
that without doing the proper successful lockref_get_not_dead() ends
up being equivalent to missing a dget(), not an extra dput(). Which
was why I was looking at unlazy_walk() -> terminate_walk().

But I really don't see anything wrong. That was the only really
obvious sequence where you changed things. Everything else seems to be
a pretty 1:1 conversion.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux