On Thu 28-11-13 13:07:24, David Howells wrote: > Jan Kara <jack@xxxxxxx> wrote: > > > > unsigned long long st_blocks; > > When we are doing this, can we please also change 'st_blocks' to > > 'st_bytes'? We track space usage in kernel in bytes for a long time so it > > would be nice to propagate it to userspace via stat instead of a special > > ioctl (at least quotacheck(8) needs to know the exact value). > > Ummm... I'm not sure about that. Ideally, every field that is provided in > the current stat() buffer must still be there. On the other hand, since > they're going to be moved around, presumably there will be a userspace > translation layer. Yeah. If someone uses xstat directly, he should know from documentation what to do. If someone uses older stat call and glibc translates it to xstat, then it is trivial for it to translate st_bytes back to st_blocks (kernel currently does this by >> 9). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
